https://bugzilla.redhat.com/show_bug.cgi?id=2335139 Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(lukasz.wojnilowic | |z@xxxxxxxxx) --- Comment #2 from Carlos Rodriguez-Fernandez <carlosrodrifernandez@xxxxxxxxx> --- Hi Lukasz, The package is pretty complete. I have one feedback, wouldn't you want to use pkgconfig instead? $ diff -u dmenu-wayland.spec.orig dmenu-wayland.spec --- dmenu-wayland.spec.orig 2025-01-01 15:40:07.432750735 -0700 +++ dmenu-wayland.spec 2025-01-01 16:03:38.828499401 -0700 @@ -13,12 +13,12 @@ Source: %{url}/archive/%{commit}/%{name}-%{short_commit}.tar.gz BuildRequires: gcc -BuildRequires: glib2-devel +BuildRequires: pkgconfig(glib-2.0) BuildRequires: pango-devel -BuildRequires: cairo-devel -BuildRequires: libxkbcommon-devel -BuildRequires: wayland-devel -BuildRequires: wayland-protocols-devel +BuildRequires: pkgconfig(cairo) +BuildRequires: pkgconfig(xkbcommon) +BuildRequires: pkgconfig(wayland-client) +BuildRequires: pkgconfig(wayland-protocols) BuildRequires: meson %description pango is the onle one that doesn't have one, but the rest do. This is the reasoning behind it: https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2335139 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335139%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
