[Bug 2335183] Review Request: golang-github-coder-websocket - Minimal and idiomatic WebSocket library for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikel@xxxxxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
Can you keep the *generate_buildrequires part, but remove the modules required
extra deps? Like this:

> %prep
> %goprep -A
> # Remove benchmark and examples to avoid extra deps
> rm -rf internal/examples internal/thirdparty

> %if %{without bootstrap}
> %generate_buildrequires
> %go_generate_buildrequires
> %endif

That way, if in the future it requires any module it should be easier to bump.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2335183

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202335183%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux