https://bugzilla.redhat.com/show_bug.cgi?id=2334700 --- Comment #4 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Issues: ======= - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files Note: Package contains %{pythonX_site(lib|arch)}/* in %files See: https://pagure.io/packaging-committee/issue/782 %{python3_sitearch}/* needs to be updated to only define files for this package or use the macros. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. We are likely going to need to patch to add a SONAME and punt upstream. [!]: License file installed when any subpackage combination is installed. LICENSE is not installed when python3-%{name} is installed. [!]: Package is not known to require an ExcludeArch tag. [!]: Package should compile and build into binary rpms on all supported architectures. Due to ExcludeArch for 32bit on python3-symengine we will need to do that in this package too. https://koji.fedoraproject.org/koji/taskinfo?taskID=127468995 [!]: Package complies to the Packaging Guidelines Unversioned SONAME in the loader path without a clear exception. %{_libdir}/lib%{name}.so.* included in both the main file and the -devel package. [!]: Package meets the Packaging Guidelines::Python Need to clean up the %files for this. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Patch0: cnkalman-shared.patch [!]: %check is present and all tests pass. There are tests, we should try to run them. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2334700 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334700%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
