[Bug 2333030] Review Request: python-symengine - SymEngine Python Wrappers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2333030



--- Comment #23 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Jonathan Steffan from comment #22)
> (In reply to Simone Caronni from comment #20)
> > > [!]: Fully versioned dependency in subpackages if applicable.
> > >      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
> > >      python3-symengine , python3-symengine-tests
> > > 
> > > Still needs updated.
> > 
> > No, it does not, please read. The source package is called python-symengine,
> > we don't want python3-symengine to require python-symengine (which is not
> > even a package).
> 
> >%package -n python3-symengine
> >Summary:        %{summary}
> >Requires:       symengine%{?_isa} >= %{version}
> 
> This doesn't seem like it should be ">=" and should rather be "="? Because
> this is an unversioned SONAME we need to be sure to install the exact
> matching C libs?

To be honest I don't know how the versioning of the two components is, I don't
know if symengine.py requires a minimum version or if the project need to be in
sync with releases.

> >%description -n python3-symengine %{common_description}
> >
> >%package -n python3-symengine-tests
> >Summary:        %{summary} tests
> >Requires:       python3-symengine = %{version}-%{release}
> 
> Shouldn't this be "python3-symengine%{?_isa} = %{version}-%{release}"?

Sounds correct, considering we're making everything go into %python3_sitearch.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2333030

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333030%23c23

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux