https://bugzilla.redhat.com/show_bug.cgi?id=2333030 --- Comment #12 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Jonathan Steffan from comment #10) > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > python3-symengine , python3-symengine-tests > > Update the Requires to match. Fixed, python3-symengine Requires: %{name}%{?_isa} = %{version}-%{release}, and python3-symengine-tests Requires: python3-symengine = %{version}-%{release} > [!]: Packages should try to preserve timestamps of original installed > files. > > unzip/zip will preserve. > We need to add -a or -p to the cp commands. Changed cp -fr to cp -ar. > python3-symengine.x86_64: W: python-bytecode-without-source > /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities. > cpython-313.opt-1.pyc > python3-symengine.x86_64: W: python-bytecode-without-source > /usr/lib64/python3.13/site-packages/symengine/__pycache__/test_utilities. > cpython-313.pyc > > We need to ship the source of these. Adjust the %files section, the source for the compiled python file is in the tests subpackage: %files -n python3-symengine -f %{pyproject_files} %license LICENSE %doc AUTHORS README.md %exclude %{python3_sitearch}/symengine/test_utilities.py %exclude %{python3_sitearch}/symengine/tests %exclude %{python3_sitearch}/symengine/__pycache__/test_utilities.*.pyc %files -n python3-symengine-tests %{python3_sitearch}/symengine/test_utilities.py %{python3_sitearch}/symengine/tests %{python3_sitearch}/symengine/__pycache__/test_utilities.*.pyc > [!]: Development files must be in a -devel package > python3-symengine.x86_64: W: devel-file-in-non-devel-package > /usr/lib64/python3.13/site-packages/symengine/lib/pywrapper.h > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_exceptions_3 > seems to indicate we need to put this one file in a -devel subpackage? If > not, maybe we need to delete it? It's required by the symengine.pxd file, so we must ship it: cdef extern from "pywrapper.h" namespace "SymEngine": > > python-symengine.src: E: description-line-too-long Python wrappers to the > C++ library SymEngine, a fast C++ symbolic manipulation library. > python3-symengine.x86_64: E: description-line-too-long Python wrappers to > the C++ library SymEngine, a fast C++ symbolic manipulation library. > python3-symengine-tests.x86_64: E: description-line-too-long Python wrappers > to the C++ library SymEngine, a fast C++ symbolic manipulation library. > > Let's just change this to "Python wrappers to the C++ library SymEngine" to > make this happy. I've just put a new line in the middle. Please note that fedora-review is not in good shape, rpmlint does not complain about this. (In reply to Davide Cavalca from comment #11) > - in %check please indent the contents of the for loop Done. > - %{?python_provide:%python_provide python3-%{srcname}} shouldn't be needed > anymore Right, removed. > - you're using %pyproject_buildrequires -t but this package isn't using tox, > so the -t is probably not needed? Correct, I don't know why, but in my mind the -t means "test" and not "tox". Removed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333030 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333030%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
