[Bug 2334845] Review Request: golang-github-bep-imagemeta - Go library for reading EXIF, IPTC and XMP image meta data from image files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2334845

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx
             Status|NEW                         |ASSIGNED
                 CC|                            |mikel@xxxxxxxxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
> %if %{without bootstrap}
> %build
> for cmd in gen; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done
> %endif

I think this is a testing app not required. If so, can you remove it? To remove
it also remove the %files section and 

> install -m 0644 -vp metadecoder_iptc_fields.json %{buildroot}%{_datarootdir}/gocode/src/github.com/bep/imagemeta

Can you replace with:

%global gosupfiles      metadecoder_iptc_fields.json

You can use
https://src.fedoraproject.org/rpms/golang-github-projectdiscovery-goflags/blob/rawhide/f/golang-github-projectdiscovery-goflags.spec#_17
as example


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2334845

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334845%23c2

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux