https://bugzilla.redhat.com/show_bug.cgi?id=2316476 --- Comment #4 from Felix Wang <topazus@xxxxxxxxxxx> --- Spec URL: https://topazus.fedorapeople.org/clap.spec SRPM URL: https://topazus.fedorapeople.org/clap-1.2.2-1.fc39.src.rpm Thanks for seeing this package. > * Including the licensing terms becomes a MUST, since a file "LICENSE" is found in the source package: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ Fixed. Added the following line: %license LICENSE > * rpmlint indicates that some of the doc files could be included: > clap-devel.x86_64: W: no-documentation Added the following line: %doc README.md > * The generic summary and description for the -devel package don't work as nicely as with other development packages. There is no main package "clap", but %name expands to "clap", and therefore the resulting summary and description look odd: > Summary : Development files for clap > Description : > This package contains development files for clap. > You've entered a much better %description for the main package and the source package. Why not use that one for the -devel package? Even more so, since the project seems to be called CLAP in doc files and on the web pages. Fixed. > * Currently not much is going on in the header files with regard to code creation and there are no shared libs, nevertheless there are extra requirements for tracking header-only "libs": https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries Fixed. Added the following line: Provides: %{name}-static = %{version}-%{release} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2316476 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316476%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
