Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocfs2-tools - programs for managing Ocfs2 file systems https://bugzilla.redhat.com/show_bug.cgi?id=431277 ------- Additional Comments From mark@xxxxxxxxxx 2008-02-05 15:43 EST ------- (In reply to comment #13) > Change the buildroot to > > %{_tmppath}/%{name}-%{version}-%{release}-root Ahh, ok. Thanks - a new version of the package and spec have been uploaded: Spec URL: http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools.spec SRPM URL: http://oss.oracle.com/~mfasheh/fedora/ocfs2-tools-1.3.9-5.20080131git.fc8.src.rpm > The part of the guidelines, I wanted you to refer to regarding static libs was, > > "In general, packagers are strongly encouraged not to ship static libs unless a > compelling reason exists." > > If you do have compelling reasons, it would be good to specify that in the > review. Upstream doesn't build dynamic libraries because the ocfs2-tools api changes quite rapidly as file system features are added / expanded. As a result, it's impossible to provide any sort of abi stability, so static libraries are provided instead. Generally, people writing ocfs2 programs are encouraged to submit their software to ocfs2-tools-devel@xxxxxxxxxxxxxx so that it can be included in the upstream ocfs2-tools distribution. The libraries that are provided in ocfs2-tools-devel are intended for interim development, and for a small number of external programs including some fs test software. > Other than those minor nit-picks, the latest spec looks ok to me. I did > a scratch build of the latest ocfs2 srpm and it builds and installs correctly. Thanks for testing! > A sponsor has to do a official review and approve your spec before you get > commit access. > > http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Ok, I will add the FE-NEEDSPONSOR field to indicate my official request for sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review