https://bugzilla.redhat.com/show_bug.cgi?id=2258036 --- Comment #13 from Antonio T. sagitter <trpost@xxxxxxxxxxxxxx> --- (In reply to david08741 from comment #9) > (In reply to Antonio T. sagitter from comment #8) > > Overall the packaging is correct. > > Approved. > > > Thanks! > > > > Issues: > > ======= > > - Dist tag is present. > I assumed this is a false positive? A conflict, maybe, between "%autorelease" vs "%{autorelease}" > > > - Please, do not use hash tag in Patch line but > > https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25. > > patch > > I find the name 25.patch not very helpful. Maybe gh-pr-25.patch? Or why > would you prefer 25.patch? https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25.patch and a comment containing the link to the "pull request" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2258036 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258036%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
