https://bugzilla.redhat.com/show_bug.cgi?id=2329823 --- Comment #2 from Simone Caronni <negativo17@xxxxxxxxx> --- 1) Please drop the first block, is not needed at all: ## START: Set by rpmautospec ## (rpmautospec version 0.7.3) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: release_number = 1; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} ## END: Set by rpmautospec 2) Please adjust version, since you are already declaring commit/date/shortcommit, use them in the version field. Version: 1181^%{date}.%{shortcommit} 3) Please pass "-p" to install commands in the install section. You can also squeeze in one line omitting mkdir: install -p -m 755 bin/linux/genie %{buildroot}%{_bindir}/genie 4) In the %changelog section, remove everything and just use %autochangelog to have the changelog automatically populated with git commit messages: %changelog %autochangelog -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2329823 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329823%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
