https://bugzilla.redhat.com/show_bug.cgi?id=2325026 Simone Caronni <negativo17@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- A couple of issues. 1) Delete the block at the top, it's not needed at all: ## START: Set by rpmautospec ## (rpmautospec version 0.7.2) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: release_number = 1; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} ## END: Set by rpmautospec 2) For the Version field, since you are declaring the %shortcommit macro above, please use in the Version field: Version: 0.0^20201207.%{shortcommit} Personally, I would do it like the following: %global commit 90d1f7f199cc55b13c7fdb5839d1409806633fdb %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global date 20201207 Name: chibicc Version: 0.0^%{date}.%{shortcommit} 3) In the install section, whenever you are using the install command, please also pass "-p" to preserve timestamps: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 4) In the %changelog section, remove everything and just use %autochangelog to have the changelog automatically populated with git commit messages: %changelog %autochangelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325026 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325026%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
