https://bugzilla.redhat.com/show_bug.cgi?id=2258036 --- Comment #9 from david08741@xxxxxxxxx --- (In reply to Antonio T. sagitter from comment #8) > Overall the packaging is correct. > Approved. > Thanks! > Issues: > ======= > - Dist tag is present. I assumed this is a false positive? > - Please, do not use hash tag in Patch line but > https://patch-diff.githubusercontent.com/raw/freegs-plasma/FreeQDSK/pull/25. > patch I find the name 25.patch not very helpful. Maybe gh-pr-25.patch? Or why would you prefer 25.patch? > - [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) > > - You may even use "%pyproject_check_import" in Check section (see > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #pyproject_check_import) before pytest Thanks, done! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2258036 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202258036%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
