https://bugzilla.redhat.com/show_bug.cgi?id=2332970 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(benson_muite@emai | |lplus.org) | Status|ASSIGNED |POST --- Comment #8 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- The(In reply to Simone Caronni from comment #3) > (In reply to Benson Muite from comment #2) > > Comments: > > a) Koji build: > > https://koji.fedoraproject.org/koji/taskinfo?taskID=126988974 > > Does not build on i686 > > Yeah, it does not. There are missing build requirements on i686. I've added > ExcludeArch: %{ix86} and added the tracking bug. > Ok. > > b) Add > > Requires: %{name}%{?_isa} = %{version}-%{release} > > in symengine-devel > > This is already satisfied when building the RPM, adding it would be > redundant: > > $ rpm -qp --requires symengine-devel-0.13.0-1.fc41.x86_64.rpm | grep > symengine > libsymengine.so.0.13()(64bit) > This is needed to ensure the license file is always included, in particular should there be any changes in the structure of the package. It should not add any maintenance burden. > > c) Build log does not seem to contain any test output. > > I think I forgot to upload the src.rpm along with the SPEC file last time, > the output is there: > > + /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure > --force-new-ctest-process -j32 > Internal ctest changing into directory: > /builddir/build/BUILD/symengine-0.13.0-build/symengine-0.13.0/redhat-linux- > build > Test project > /builddir/build/BUILD/symengine-0.13.0-build/symengine-0.13.0/redhat-linux- > build > Start 1: test_rcp > [...] > 65/65 Test #52: test_lambda_double ............... Passed 0.25 sec > > 100% tests passed, 0 tests failed out of 65 > > Total Test time (real) = 0.32 sec > + RPM_EC=0 > Ok. They are there in the current build. > > d) Installed package has cereal headers which are BSD-3-Clause > > If these are needed, consider softlinking to the cereal package in Fedora: > > https://packages.fedoraproject.org/pkgs/cereal/ > > or if this is not possible, indicate it is bundled and add the appropriate > > license and > > add a license breakdown. > > Fixed, it can actually be built with -DWITH_SYSTEM_CEREAL=on. > Great. > > e) Please ensure that > > /usr/lib64/cmake/symengine > > is owned > > Fixed. > Thanks. > Spec URL: https://slaanesh.fedorapeople.org/review/symengine.spec > SRPM URL: > https://slaanesh.fedorapeople.org/review/symengine-0.13.0-1.fc41.src.rpm Approved. Please make change (b) before import. If time and expertise allow review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2329630 https://bugzilla.redhat.com/show_bug.cgi?id=2329823 https://bugzilla.redhat.com/show_bug.cgi?id=2325026 would be appreciated. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332970 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332970%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
