[Bug 2332970] Review Request: symengine - Fast symbolic manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2332970



--- Comment #3 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to Benson Muite from comment #2)
> Comments:
> a) Koji build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=126988974
> Does not build on i686

Yeah, it does not. There are missing build requirements on i686. I've added
ExcludeArch: %{ix86} and added the tracking bug.

> b) Add
> Requires: %{name}%{?_isa} = %{version}-%{release}
> in symengine-devel

This is already satisfied when building the RPM, adding it would be redundant:

$ rpm -qp --requires symengine-devel-0.13.0-1.fc41.x86_64.rpm | grep symengine
libsymengine.so.0.13()(64bit)

> c) Build log does not seem to contain any test output.

I think I forgot to upload the src.rpm along with the SPEC file last time, the
output is there:

+ /usr/bin/ctest --test-dir redhat-linux-build --output-on-failure
--force-new-ctest-process -j32
Internal ctest changing into directory:
/builddir/build/BUILD/symengine-0.13.0-build/symengine-0.13.0/redhat-linux-build
Test project
/builddir/build/BUILD/symengine-0.13.0-build/symengine-0.13.0/redhat-linux-build
      Start  1: test_rcp
[...]
65/65 Test #52: test_lambda_double ...............   Passed    0.25 sec

100% tests passed, 0 tests failed out of 65

Total Test time (real) =   0.32 sec
+ RPM_EC=0

> d) Installed package has cereal headers which are BSD-3-Clause
> If these are needed, consider softlinking to the cereal package in Fedora:
> https://packages.fedoraproject.org/pkgs/cereal/
> or if this is not possible, indicate it is bundled and add the appropriate
> license and
> add a license breakdown.

Fixed, it can actually be built with -DWITH_SYSTEM_CEREAL=on.

> e) Please ensure that
> /usr/lib64/cmake/symengine
> is owned

Fixed.

Spec URL: https://slaanesh.fedorapeople.org/review/symengine.spec
SRPM URL:
https://slaanesh.fedorapeople.org/review/symengine-0.13.0-1.fc41.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2332970

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332970%23c3

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux