https://bugzilla.redhat.com/show_bug.cgi?id=2332843 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "Boost Software License 1.0". 61 files have unknown license. Boost Software License 1.0 sciplot-0.2.2/tests/catch.hpp [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/sciplot(sciplot- devel), /usr/include/sciplot/specs(sciplot-devel), /usr/share/sciplot(sciplot-devel) [!]: Package does not generate any conflict. I'm not certain how to deal with this because it's a compat package. I think "Conflicts: sciplot-devel" but we should double check. [!]: Package is named according to the Package Naming Guidelines. [!]: Package complies to the Packaging Guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple These look good after research. [!]: Final provides and requires are sane (see attachments). sciplot0.2-devel sciplot0.2-devel(x86-64) sciplot0.2-static Based on my interpretation of the guidelines for multiple packages with the same base name, this should be correct. Just want to double check. [!]: Latest version is packaged. Intentional. The latest v2 version is packaged. [!]: %check is present and all tests pass. We should run the tests as part of the build process. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2332843 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332843%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
