https://bugzilla.redhat.com/show_bug.cgi?id=2332842 --- Comment #3 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- Issues: ======= - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: cnmatrix-devel. Does not provide -static: cnmatrix-devel. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries cnmatrix-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/libcnmatrix.a We should either delete this file or put it in a -static subpackage if it's required, per the referenced guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "BSD 2-Clause License". 19 files have unknown license. cmake/FindEigen3.cmake is BSD-2-Clause [!]: Package should compile and build into binary rpms on all supported architectures. 32bit fails due to static lib handling: mv: '/builddir/build/BUILD/cnmatrix-0.0_20220215git5936c62-build/BUILDROOT/usr/lib/libcnmatrix.a' and '/builddir/build/BUILD/cnmatrix-0.0_20220215git5936c62-build/BUILDROOT/usr/lib/libcnmatrix.a' are the same file [!]: %check is present and all tests pass. We should run the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2332842 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332842%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
