https://bugzilla.redhat.com/show_bug.cgi?id=2245746 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #24 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Provides: bundled(gnulib) in place as required. Note: Bundled gnulib but no Provides: bundled(gnulib) See: https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License (with License Retention)", "X11 License [generated file]", "GNU Free Documentation License v1.3 or later", "GNU Free Documentation License v1.1 or later", "GNU Library General Public License v2 or later", "GNU Lesser General Public License v2.1 or later", "GNU Lesser General Public License v3.0 or later", "FSF Unlimited License (with License Retention) and/or GNU General Public License and/or GNU Lesser General Public License", "GNU General Public License". 64 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/rush/2245746-rush/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 77328 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rush-2.4-1.fc42.x86_64.rpm rush-debuginfo-2.4-1.fc42.x86_64.rpm rush-debugsource-2.4-1.fc42.x86_64.rpm rush-2.4-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp73hzbdce')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 27 filtered, 0 badness; has taken 5.6 s Rpmlint (debuginfo) ------------------- Checking: rush-debuginfo-2.4-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6p5b7mrp')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 14 filtered, 0 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 26 filtered, 0 badness; has taken 7.6 s Source checksums ---------------- http://ftp.gnu.org/gnu/rush/rush-2.4.tar.xz.sig : CHECKSUM(SHA256) this package : 1bf346dd872779e62355554d92ccae386d6e51254f7ef2a12262d5e473c91284 CHECKSUM(SHA256) upstream package : 1bf346dd872779e62355554d92ccae386d6e51254f7ef2a12262d5e473c91284 http://ftp.gnu.org/gnu/rush/rush-2.4.tar.xz : CHECKSUM(SHA256) this package : fa95af9d2c7b635581841cc27a1d27af611f60dd962113a93d23a8874aa060f4 CHECKSUM(SHA256) upstream package : fa95af9d2c7b635581841cc27a1d27af611f60dd962113a93d23a8874aa060f4 Requires -------- rush (rpmlib, GLIBC filtered): /usr/bin/sh config(rush) libc.so.6()(64bit) rtld(GNU_HASH) rush-debuginfo (rpmlib, GLIBC filtered): rush-debugsource (rpmlib, GLIBC filtered): Provides -------- rush: config(rush) rush rush(x86-64) rush-debuginfo: debuginfo(build-id) rush-debuginfo rush-debuginfo(x86-64) rush-debugsource: rush-debugsource rush-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2245746 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Ocaml, Perl, R, Haskell, SugarActivity, Python, Java, PHP, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Koji build https://koji.fedoraproject.org/koji/taskinfo?taskID=127042014 b) Indicate that Gnulib ( https://www.gnu.org/software/gnulib/ ) is bundled by modifying BuildRequires: gnupg2 BuildRequires: make to BuildRequires: gnupg2 BuildRequires: make Provides: bundled(gnulib) Alternatively, you could remove the gnu directory, and add a BuildRequires: gnulib-devel but, it maybe that what is used in the bundled version differs from what is in Fedora/Epel and will not allow the package to build. b) Can you add a brief description of which licenses apply to which files that are either packaged directly, or built into distributed software in the spec file? For example, just above the license line add comments like: # Documentation under GFDL1.1-or-later AND GFDL 1.3 or later # Files from GNULib under LGPL-2.0-or-later AND LGPL-3.0-or-later AND LGPL-3.1-or-later # Main code and man pages under GPL-3.0-or-later GNU Free Documentation License v1.1 or later -------------------------------------------- rush-2.4-build/rush-2.4/doc/strftime.texi GNU Free Documentation License v1.3 or later -------------------------------------------- rush-2.4-build/rush-2.4/doc/rush.info rush-2.4-build/rush-2.4/doc/rush.texi GNU General Public License -------------------------- rush-2.4-build/rush-2.4/doc/imprimatur/rendition.texi GNU General Public License v3.0 or later ---------------------------------------- rush-2.4-build/rush-2.4/doc/imprimatur/emptynodes.awk rush-2.4-build/rush-2.4/doc/imprimatur/mastermenu.el rush-2.4-build/rush-2.4/doc/imprimatur/untabify.el rush-2.4-build/rush-2.4/doc/rush-po.1 rush-2.4-build/rush-2.4/doc/rush.8 rush-2.4-build/rush-2.4/doc/rush.rc.5 rush-2.4-build/rush-2.4/doc/rushlast.1 rush-2.4-build/rush-2.4/doc/rushwho.1 rush-2.4-build/rush-2.4/gnu/basename.c rush-2.4-build/rush-2.4/gnu/dirname.c rush-2.4-build/rush-2.4/gnu/fprintftime.c rush-2.4-build/rush-2.4/gnu/fprintftime.h rush-2.4-build/rush-2.4/gnu/xalloc.h rush-2.4-build/rush-2.4/gnu/xmalloc.c rush-2.4-build/rush-2.4/lib/argcv.c rush-2.4-build/rush-2.4/lib/i18n.c rush-2.4-build/rush-2.4/lib/librush.h rush-2.4-build/rush-2.4/lib/progname.c rush-2.4-build/rush-2.4/lib/readfmt.c rush-2.4-build/rush-2.4/lib/rushdb.c rush-2.4-build/rush-2.4/lib/slist.c rush-2.4-build/rush-2.4/lib/utmp.c rush-2.4-build/rush-2.4/lib/version.c rush-2.4-build/rush-2.4/lib/wildmatch.c rush-2.4-build/rush-2.4/lib/wordsplit/wordsplit.c rush-2.4-build/rush-2.4/lib/wordsplit/wordsplit.h rush-2.4-build/rush-2.4/lib/wtmp.c rush-2.4-build/rush-2.4/src/cf.c rush-2.4-build/rush-2.4/src/cf.h rush-2.4-build/rush-2.4/src/cfck.c rush-2.4-build/rush-2.4/src/cfgram.c rush-2.4-build/rush-2.4/src/cfgram.h rush-2.4-build/rush-2.4/src/cfgram.y rush-2.4-build/rush-2.4/src/cflex.l rush-2.4-build/rush-2.4/src/config.c rush-2.4-build/rush-2.4/src/defconf.sed rush-2.4-build/rush-2.4/src/dump.c rush-2.4-build/rush-2.4/src/limits.c rush-2.4-build/rush-2.4/src/map.c rush-2.4-build/rush-2.4/src/rlopt.h rush-2.4-build/rush-2.4/src/rlopt.opt rush-2.4-build/rush-2.4/src/rush-po rush-2.4-build/rush-2.4/src/rush.c rush-2.4-build/rush-2.4/src/rush.h rush-2.4-build/rush-2.4/src/rushlast.c rush-2.4-build/rush-2.4/src/rushopt.h rush-2.4-build/rush-2.4/src/rushopt.opt rush-2.4-build/rush-2.4/src/rushwho.c rush-2.4-build/rush-2.4/src/rwopt.h rush-2.4-build/rush-2.4/src/rwopt.opt rush-2.4-build/rush-2.4/src/socket.c rush-2.4-build/rush-2.4/src/transform.c GNU Lesser General Public License v2.1 or later ----------------------------------------------- rush-2.4-build/rush-2.4/gnu/alloca.in.h rush-2.4-build/rush-2.4/gnu/anytostr.c rush-2.4-build/rush-2.4/gnu/assert.in.h rush-2.4-build/rush-2.4/gnu/attribute.h rush-2.4-build/rush-2.4/gnu/basename-lgpl.c rush-2.4-build/rush-2.4/gnu/basename-lgpl.h rush-2.4-build/rush-2.4/gnu/btowc.c rush-2.4-build/rush-2.4/gnu/c-ctype.c rush-2.4-build/rush-2.4/gnu/c-ctype.h rush-2.4-build/rush-2.4/gnu/calloc.c rush-2.4-build/rush-2.4/gnu/cdefs.h rush-2.4-build/rush-2.4/gnu/cloexec.c rush-2.4-build/rush-2.4/gnu/cloexec.h rush-2.4-build/rush-2.4/gnu/close.c rush-2.4-build/rush-2.4/gnu/dirname-lgpl.c rush-2.4-build/rush-2.4/gnu/dirname.h rush-2.4-build/rush-2.4/gnu/dup2.c rush-2.4-build/rush-2.4/gnu/dynarray.h rush-2.4-build/rush-2.4/gnu/errno.in.h rush-2.4-build/rush-2.4/gnu/error.c rush-2.4-build/rush-2.4/gnu/error.in.h rush-2.4-build/rush-2.4/gnu/fcntl.c rush-2.4-build/rush-2.4/gnu/fcntl.in.h rush-2.4-build/rush-2.4/gnu/fd-hook.c rush-2.4-build/rush-2.4/gnu/fd-hook.h rush-2.4-build/rush-2.4/gnu/filename.h rush-2.4-build/rush-2.4/gnu/flexmember.h rush-2.4-build/rush-2.4/gnu/free.c rush-2.4-build/rush-2.4/gnu/fstat.c rush-2.4-build/rush-2.4/gnu/getdelim.c rush-2.4-build/rush-2.4/gnu/getdtablesize.c rush-2.4-build/rush-2.4/gnu/getline.c rush-2.4-build/rush-2.4/gnu/getopt-cdefs.in.h rush-2.4-build/rush-2.4/gnu/getopt-core.h rush-2.4-build/rush-2.4/gnu/getopt-ext.h rush-2.4-build/rush-2.4/gnu/getopt-pfx-core.h rush-2.4-build/rush-2.4/gnu/getopt-pfx-ext.h rush-2.4-build/rush-2.4/gnu/getopt.c rush-2.4-build/rush-2.4/gnu/getopt.in.h rush-2.4-build/rush-2.4/gnu/getopt1.c rush-2.4-build/rush-2.4/gnu/getopt_int.h rush-2.4-build/rush-2.4/gnu/getprogname.c rush-2.4-build/rush-2.4/gnu/getprogname.h rush-2.4-build/rush-2.4/gnu/gettext.h rush-2.4-build/rush-2.4/gnu/glthread/lock.c rush-2.4-build/rush-2.4/gnu/glthread/lock.h rush-2.4-build/rush-2.4/gnu/glthread/threadlib.c rush-2.4-build/rush-2.4/gnu/hard-locale.c rush-2.4-build/rush-2.4/gnu/hard-locale.h rush-2.4-build/rush-2.4/gnu/ialloc.c rush-2.4-build/rush-2.4/gnu/ialloc.h rush-2.4-build/rush-2.4/gnu/idx.h rush-2.4-build/rush-2.4/gnu/imaxtostr.c rush-2.4-build/rush-2.4/gnu/intprops-internal.h rush-2.4-build/rush-2.4/gnu/intprops.h rush-2.4-build/rush-2.4/gnu/inttostr.c rush-2.4-build/rush-2.4/gnu/inttostr.h rush-2.4-build/rush-2.4/gnu/inttypes.in.h rush-2.4-build/rush-2.4/gnu/langinfo.in.h rush-2.4-build/rush-2.4/gnu/lc-charset-dispatch.c rush-2.4-build/rush-2.4/gnu/lc-charset-dispatch.h rush-2.4-build/rush-2.4/gnu/libc-config.h rush-2.4-build/rush-2.4/gnu/limits.in.h rush-2.4-build/rush-2.4/gnu/localcharset.c rush-2.4-build/rush-2.4/gnu/localcharset.h rush-2.4-build/rush-2.4/gnu/locale.in.h rush-2.4-build/rush-2.4/gnu/localeconv.c rush-2.4-build/rush-2.4/gnu/malloc.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray-skeleton.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray.h rush-2.4-build/rush-2.4/gnu/malloc/dynarray_at_failure.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray_emplace_enlarge.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray_finalize.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray_resize.c rush-2.4-build/rush-2.4/gnu/malloc/dynarray_resize_clear.c rush-2.4-build/rush-2.4/gnu/malloca.c rush-2.4-build/rush-2.4/gnu/malloca.h rush-2.4-build/rush-2.4/gnu/mbrtowc-impl-utf8.h rush-2.4-build/rush-2.4/gnu/mbrtowc-impl.h rush-2.4-build/rush-2.4/gnu/mbrtowc.c rush-2.4-build/rush-2.4/gnu/mbsinit.c rush-2.4-build/rush-2.4/gnu/mbtowc-impl.h rush-2.4-build/rush-2.4/gnu/mbtowc-lock.c rush-2.4-build/rush-2.4/gnu/mbtowc-lock.h rush-2.4-build/rush-2.4/gnu/mbtowc.c rush-2.4-build/rush-2.4/gnu/minmax.h rush-2.4-build/rush-2.4/gnu/mktime-internal.h rush-2.4-build/rush-2.4/gnu/mktime.c rush-2.4-build/rush-2.4/gnu/msvc-inval.c rush-2.4-build/rush-2.4/gnu/msvc-inval.h rush-2.4-build/rush-2.4/gnu/msvc-nothrow.c rush-2.4-build/rush-2.4/gnu/msvc-nothrow.h rush-2.4-build/rush-2.4/gnu/nl_langinfo-lock.c rush-2.4-build/rush-2.4/gnu/nl_langinfo.c rush-2.4-build/rush-2.4/gnu/offtostr.c rush-2.4-build/rush-2.4/gnu/open.c rush-2.4-build/rush-2.4/gnu/pathmax.h rush-2.4-build/rush-2.4/gnu/realloc.c rush-2.4-build/rush-2.4/gnu/reallocarray.c rush-2.4-build/rush-2.4/gnu/regcomp.c rush-2.4-build/rush-2.4/gnu/regex.c rush-2.4-build/rush-2.4/gnu/regex.h rush-2.4-build/rush-2.4/gnu/regex_internal.c rush-2.4-build/rush-2.4/gnu/regex_internal.h rush-2.4-build/rush-2.4/gnu/regexec.c rush-2.4-build/rush-2.4/gnu/setenv.c rush-2.4-build/rush-2.4/gnu/setlocale-lock.c rush-2.4-build/rush-2.4/gnu/setlocale_null.c rush-2.4-build/rush-2.4/gnu/setlocale_null.h rush-2.4-build/rush-2.4/gnu/stat-time.c rush-2.4-build/rush-2.4/gnu/stat-time.h rush-2.4-build/rush-2.4/gnu/stat-w32.c rush-2.4-build/rush-2.4/gnu/stat-w32.h rush-2.4-build/rush-2.4/gnu/stat.c rush-2.4-build/rush-2.4/gnu/stdckdint.in.h rush-2.4-build/rush-2.4/gnu/stddef.in.h rush-2.4-build/rush-2.4/gnu/stdint.in.h rush-2.4-build/rush-2.4/gnu/stdio-read.c rush-2.4-build/rush-2.4/gnu/stdio-write.c rush-2.4-build/rush-2.4/gnu/stdio.in.h rush-2.4-build/rush-2.4/gnu/stdlib.in.h rush-2.4-build/rush-2.4/gnu/streq.h rush-2.4-build/rush-2.4/gnu/strerror-override.c rush-2.4-build/rush-2.4/gnu/strerror-override.h rush-2.4-build/rush-2.4/gnu/strerror.c rush-2.4-build/rush-2.4/gnu/string.in.h rush-2.4-build/rush-2.4/gnu/stripslash.c rush-2.4-build/rush-2.4/gnu/sys_stat.in.h rush-2.4-build/rush-2.4/gnu/sys_types.in.h rush-2.4-build/rush-2.4/gnu/time.in.h rush-2.4-build/rush-2.4/gnu/time_r.c rush-2.4-build/rush-2.4/gnu/timegm.c rush-2.4-build/rush-2.4/gnu/uinttostr.c rush-2.4-build/rush-2.4/gnu/umaxtostr.c rush-2.4-build/rush-2.4/gnu/unistd.c rush-2.4-build/rush-2.4/gnu/unistd.in.h rush-2.4-build/rush-2.4/gnu/unsetenv.c rush-2.4-build/rush-2.4/gnu/verify.h rush-2.4-build/rush-2.4/gnu/wchar.in.h rush-2.4-build/rush-2.4/gnu/wcrtomb.c rush-2.4-build/rush-2.4/gnu/wctype-h.c rush-2.4-build/rush-2.4/gnu/wctype.in.h rush-2.4-build/rush-2.4/gnu/windows-initguard.h rush-2.4-build/rush-2.4/gnu/windows-mutex.c rush-2.4-build/rush-2.4/gnu/windows-mutex.h rush-2.4-build/rush-2.4/gnu/windows-once.c rush-2.4-build/rush-2.4/gnu/windows-once.h rush-2.4-build/rush-2.4/gnu/windows-recmutex.c rush-2.4-build/rush-2.4/gnu/windows-recmutex.h rush-2.4-build/rush-2.4/gnu/windows-rwlock.c rush-2.4-build/rush-2.4/gnu/windows-rwlock.h rush-2.4-build/rush-2.4/gnu/xalloc-oversized.h GNU Lesser General Public License v3.0 or later ----------------------------------------------- rush-2.4-build/rush-2.4/gnu/nstrftime.c rush-2.4-build/rush-2.4/gnu/strftime.h rush-2.4-build/rush-2.4/gnu/time-internal.h rush-2.4-build/rush-2.4/gnu/time_rz.c rush-2.4-build/rush-2.4/gnu/tzset.c GNU Library General Public License v2 or later ---------------------------------------------- rush-2.4-build/rush-2.4/gnu/_Noreturn.h rush-2.4-build/rush-2.4/gnu/arg-nonnull.h rush-2.4-build/rush-2.4/gnu/c++defs.h rush-2.4-build/rush-2.4/gnu/warn-on-use.h c) Approved. Please make change (b) before import. d) Review of one of https://bugzilla.redhat.com/show_bug.cgi?id=2325026 https://bugzilla.redhat.com/show_bug.cgi?id=2329630 https://bugzilla.redhat.com/show_bug.cgi?id=2321770 would be appreciated if time allows. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2245746 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202245746%23c24 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
