https://bugzilla.redhat.com/show_bug.cgi?id=2333373 solomoncyj@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |solomoncyj@xxxxxxxxx --- Comment #6 from solomoncyj@xxxxxxxxx --- few things - ./autogen.sh just calls autorenconf, so replacve it with autoreconf --install --force --verbose for better transperency for the patch you can attach the .patch url for the pr[1] you could try looking into forge macros, which could make the spec file a bit more readable[2] also, you do not need make after installing automake [1] https://patch-diff.githubusercontent.com/raw/simonccarter/sta/pull/13.patch [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333373 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333373%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
