Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-eBay - Perl Interface to XML based eBay API https://bugzilla.redhat.com/show_bug.cgi?id=428113 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-02-05 05:01 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 175674e914326a6af84564acfb57286b Net-eBay-0.46.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test output is t/00-load.........# Testing Net::eBay 0.46, Perl 5.008008, /usr/bin/perl ok t/pod-coverage....ok t/pod.............ok All tests successful. Files=3, Tests=22, 1 wallclock secs ( 0.64 cusr + 0.05 csys = 0.69 CPU) + Package perl-Net-eBay-0.46-1.fc9 -> Provides: perl(Net::eBay) = 0.46 Requires: /usr/bin/perl perl(Carp) perl(Cwd) perl(Data::Dumper) perl(DateTime::Precise) perl(Getopt::Long) perl(HTML::FormatText) perl(HTML::PrettyPrinter) perl(HTML::TreeBuilder) perl(HTTP::Date) perl(HTTP::Request::Common) perl(HTTP::Status) perl(LWP::UserAgent) perl(Net::eBay) perl(Text::Format) perl(XML::Dumper) perl(XML::Simple) perl(strict) perl(utf8) perl(vars) perl(warnings) SHOULD: Remove OPTIMIZE="$RPM_OPT_FLAGS" from make coammand APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review