[ ]: Package is not known to require an ExcludeArch tag.
>> This has a comment in the .spec file why it is so; not buildable on 32-bit platforms
[ ]: Package complies to the Packaging Guidelines
>> That I cannot and should not answer ;-)
[ ]: Package functions as described.
>> There are three test programs in /usr/share/doc/gdbuspp/ with compile instructions in the source files.
>> Build all of them, start the example-service first, then test the two other programs
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
>> This sounds odd ... given that all %Source references points at a https:// and spectool -gf works
[ ]: Package should compile and build into binary rpms on all supported
architectures.
>> I believe this is true - all except 32-bit platforms do build (Koji build should be able to confirm)
[ ]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: #%%define releasetag .qa1,
#%%define versiontag _qa1
>> I can change this ... I just find it valuable to keep it there as documentation on how to
>> handle tagged versions, as documented in the comment above. Not sure if %global is the right
>> alternative in this case.
IF there are anything else I can do to clarify details or fix, keep me posted!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2330591
Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330591%23c12
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
