https://bugzilla.redhat.com/show_bug.cgi?id=2188329 --- Comment #66 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Thanks for the review > Tests are included in php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz but are not > run in %check. If you do not think it is practical to run tests, you can use > 1.33.0.tar.gz instead. Test are run in %check So I choose to remove abnfgen from generated archive https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/commit/?id=f13996b09ae50ad9a505372432a26c9189220e86 I also switched spec license from CC-BY-SA-4.0 (only allowed for content in new Guidelines), by CECILL-1.2 (allowed for code), which is a global change in progress for all my packages. Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git/plain/php-phpstan-phpdoc-parser.spec?id=f13996b09ae50ad9a505372432a26c9189220e86 SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.33.0-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2188329 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202188329%23c66 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
