[Bug 2332550] Review Request: trustee-guest-components - attest and get secrets from Trustee

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2332550



--- Comment #9 from Cole Robinson <crobinso@xxxxxxxxxx> ---
(In reply to Uri Lublin from comment #6)

> > Does the package build without the un-reviewed cvm/vtpm bits enabled? If
> > it's simple to drop those, maybe do that, and then enable them in a follow
> > up commit once packages land, so this package isn't blocked.
> 
> It can be built with an added patch to remove the Azure attesters, so that
> only snp-attester is enabled, or by modifying
> 0006-Fedora-attester-pick-attesters-in-all-attesters.patch
> diff --git a/attestation-agent/attester/Cargo.toml
> b/attestation-agent/attester/Cargo.toml
> index 4e16347..1451560 100644
> --- a/attestation-agent/attester/Cargo.toml
> +++ b/attestation-agent/attester/Cargo.toml
> @@ -34,8 +34,6 @@ required-features = ["bin"]
>  [features]
>  default = ["all-attesters"]
>  all-attesters = [
> -    "az-snp-vtpm-attester",
> -    "az-tdx-vtpm-attester",
>      "snp-attester",
>  ]

snp-attester is enough for initial package review IMO, that's useful
functionality on its own.
Will let you parallellize the review process a bit.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2332550

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332550%23c9

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux