https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Uri Lublin from comment #6) (...) > > > , "comments" = [ "clap version is 4.5.19" ] }, > > > > Interesting that this seems to work fine when upstream's version string is > > says they explicitly want 4.2. Do you know what that's about? Maybe want to > > raise with upstream and mention in the patch comment. > > Without it (commenting out Patch10 in the spec-file) the build fails with: > (crate(clap/default) >= 4.2.7 with crate(clap/default) < 4.3.0~) is needed > by trustee-guest-components-0.10.0^124.git0061d03-1.fc42.x86_64 > (crate(clap/derive) >= 4.2.7 with crate(clap/derive) < 4.3.0~) is needed by > trustee-guest-components-0.10.0^124.git0061d03-1.fc42.x86_64 > > > Running "dnf list rust-clap*-devel" shows there are > rust-clap2 and rust-clap3 packages but no rust-clap4.2 packages. > > > Commit 2d8dcd3 message says: > versions: Downgrade clap > > - Downgrade clap to get to a version that builds on rust 1.69 > - clap 4.3 states that it requires rust 1.65, but it pulls in > clap_lex 0.5 as a dependency, which requires rust 1.70. > The newest version of clap_lex that will build on 1.69 is 0.4 and > the newest version of clap that depends on 0.4 is currently 4.2.7, > which is how I got to this version > > Fixes: #336 > Signed-off-by: stevenhorsman <steven@xxxxxxxxxx> > --- > > In Fedora rust is 1.83 and rust-clap_lex-devel is 0.7.4. > > I can change it back to "4" instead of "4.5.19" if it's better. We can only provide one package per *major version*. So clap v2, clap v3, and clap v4. The reason for a projects to restrict to a specific *minor* version of clap (compatibility with older versions of the Rust compiler) do not apply for packaging purposes, so these can be relaxed from ">=4.2.7,<4.3" to "^4.2.7" (equivalent to ">=4.2.7,<5"). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332550%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
