https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #5 from Cole Robinson <crobinso@xxxxxxxxxx> --- (In reply to Uri Lublin from comment #3) > rust2rpm.toml: ... > extra-sources = [ > ] guess you can drop this bit, or is there a reason it's empty? > , "comments" = [ "clap version is 4.5.19" ] }, Interesting that this seems to work fine when upstream's version string is says they explicitly want 4.2. Do you know what that's about? Maybe want to raise with upstream and mention in the patch comment. > { "number" = 12, "file" = > "0012-Fedora-kbs_protocol-Cargo.toml-add-package.license.patch" , "comments" > = [ "add package.license to kbs_protocol/Cargo.toml" ] }, Something to raise with upstream? > { "number" = 13, "file" = > "0013-Fedora-tokio-version-is-1.41.patch" , "comments" = [ "tokio version is > 1.41" ] }, tokio 1.42 is in fedora now, you can drop this Does the package build without the un-reviewed cvm/vtpm bits enabled? If it's simple to drop those, maybe do that, and then enable them in a follow up commit once packages land, so this package isn't blocked. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2332550 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202332550%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
