https://bugzilla.redhat.com/show_bug.cgi?id=2327650 --- Comment #12 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some comments: 1. You don't need to put the whole output of %cargo_license into the spec file, that is what the output of %cargo_license_summary is for. 2. The output of %cargo_license should be written to a file, and that file included in the package. (rust2rpm should do it this way?) 3. You have disabled running tests. Why? Please document why you can't run tests, or ideally, run at least *some* tests. 4. The package name is a bit strange. The executable is just "aw-server", you could just name the package "aw-server" too, it wouldn't conflict with any existing package. (and it would also mirror aw-sync executable being in the aw-sync package). If you want the source package name to remain "aw-server-rust" to match the upstream project, that's fine, but I would recommend to make the built packages just have the names "aw-server" and "aw-sync". 5. The order of sections in the spec file is very unusual - I would recommend to do <packages> <scriptlets> <file lists>. 6. This is more complicated than it needs to be: > install -Dm 0755 %{_builddir}/%{name}-%{commit}/target/rpm/{aw-server,aw-sync} -t %{buildroot}%{_bindir} Just do > install -Dm 0755 target/rpm/{aw-server,aw-sync} -t %{buildroot}%{_bindir} 7. You've included a systemd user session unit, but haven't added the necessary scriptlets for it: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units 8. Patch 1 looks strange. Is it OK to just remove the openssl crate dependency entirely? I would have just removed the "vendored" feature from it. I wonder why this still compiles with the dependency removed entirely ... 9. In general, I would recommend to split patches into logical units, not split by which file they touch. 10. The aw-webui subdirectory is empty (which might explain why things fail) - it's an uninitialized git submodule. I suspect that you will actually need to include those sources separately. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2327650 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202327650%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
