[Bug 2329101] Review Request: rust-picky-test-data - Test data for the picky crates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2329101



--- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
See also comment here:
https://github.com/Devolutions/picky-rs/issues/332#issuecomment-2531885812 and
my followup.
Not sure why they feel so "attacked" by the issue I filed ...

I would suggest the following next steps to move this package along:

1. include license texts from upstream GitHub project as separate sources until
upstream includes them in the published crates

> Source1: https://github.com/Devolutions/picky-rs/raw/picky-test-data-0.1.0/LICENSE-APACHE
> Source2: https://github.com/Devolutions/picky-rs/raw/picky-test-data-0.1.0/LICENSE-MIT

in %prep:

> cp -pav %{SOURCE1} %{SOURCE2} .

in %files devel:

replace FIXME item with

> %license %{crate_instdir}/LICENSE-APACHE
> %license %{crate_instdir}/LICENSE-MIT

2. link upstream ticket regarding source of test data (i.e. document in the
spec file that the files are either generated manually, or a certificate chain
from some other provider to test some edge case)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2329101

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329101%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux