[Bug 2331669] Review Request: sc-im - rpm packege for vim-like spreadsheet calculator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2331669



--- Comment #25 from Jan Staněk <jstanek@xxxxxxxxxx> ---
Issues highlighted at the top; full review log below.

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/sc-im

Add `%dir %{_datadir}/sc-im` line in %files – you have to own the directory as
well.

> sc-im.spec:53: W: macro-in-comment %check

RPM expands macros even in (shell) comments; double the % sign: `%%check`.

> sc-im.src: E: description-line-too-long Spreadsheet Calculator Improvised, aka sc-im, is an ncurses based, vim-like spreadsheet calculator.
> sc-im.src: E: description-line-too-long sc-im is based on sc, whose original authors are James Gosling and Mark Weiser, and mods were later added by Chuck Martin.

Apparently, the %description text should be re-flown to 80-character line
limit.
Hint: Since I've seen you using nvim, the `gq` motion should do that for you.
;-) (:help gq).

---

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 4-Clause License", "GNU Lesser
     General Public License v3.0 or later". 167 files have unknown license.
     Detailed output of licensecheck in
     /home/jstanek/redhat/fedora/review/2331669-sc-im/licensecheck.txt
[x]: Package requires other packages for directories it uses.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/sc-im
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 35176 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Sources can be downloaded from URI in Source: tag
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: sc-im-0.8.4-3.fc42.x86_64.rpm
          sc-im-0.8.4-3.fc42.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpu_s68dbe')]
checks: 32, packages: 2

sc-im.src: E: spelling-error ('ncurses', 'Summary(en_US) ncurses -> nurses,
curses, n curses')
sc-im.src: E: spelling-error ('ncurses', '%description -l en_US ncurses ->
nurses, curses, n curses')
sc-im.x86_64: E: spelling-error ('ncurses', 'Summary(en_US) ncurses -> nurses,
curses, n curses')
sc-im.x86_64: E: spelling-error ('ncurses', '%description -l en_US ncurses ->
nurses, curses, n curses')
sc-im.x86_64: W: no-manual-page-for-binary scopen
sc-im.spec:53: W: macro-in-comment %check
sc-im.x86_64: W: file-not-utf8 /usr/share/doc/sc-im/y2l.readme
sc-im.src: E: description-line-too-long Spreadsheet Calculator Improvised, aka
sc-im, is an ncurses based, vim-like spreadsheet calculator.
sc-im.src: E: description-line-too-long sc-im is based on sc, whose original
authors are James Gosling and Mark Weiser, and mods were later added by Chuck
Martin.
sc-im.x86_64: E: description-line-too-long Spreadsheet Calculator Improvised,
aka sc-im, is an ncurses based, vim-like spreadsheet calculator.
sc-im.x86_64: E: description-line-too-long sc-im is based on sc, whose original
authors are James Gosling and Mark Weiser, and mods were later added by Chuck
Martin.
 2 packages and 0 specfiles checked; 8 errors, 3 warnings, 7 filtered, 8
badness; has taken 0.2 s




Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
sc-im (rpmlib, GLIBC filtered):
    /usr/bin/bash
    libc.so.6()(64bit)
    libm.so.6()(64bit)
    libncursesw.so.6()(64bit)
    libtinfo.so.6()(64bit)
    libxlsreader.so.8()(64bit)
    rtld(GNU_HASH)



Provides
--------
sc-im:
    sc-im
    sc-im(x86-64)


Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2331669
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: PHP, Python, R, fonts, Haskell, Perl, SugarActivity, Ocaml,
Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

---

Side note: I'm leaving for my Xmas time off today; feel free to hunt down
someone else to finish the review. Otherwise, see you in the new year!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2331669

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331669%23c25

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux