https://bugzilla.redhat.com/show_bug.cgi?id=2331669 --- Comment #19 from Jan Staněk <jstanek@xxxxxxxxxx> --- Tomas, I see the changes in the spec file; however, a comment also left here about what's changed/what have you done would be appreciated. ;-) > Could you please explore, if there is a chance to execute the test suite in `%check` section? If not, it would still be valuable to record this information in .spec file. On my machine (raw, out-of package compilation), all tests pass except test7.sh. So there is the possibility to rename the known-failing test (i.e. mv test7.sh test7.sh.known-fail) and run the rest. That would at least tell us if anything new broke in further updates. Additionally, I do not think all the listed dependencies are build-time (BuildRequires). At least the xclip and gnuplot ones seems like run-time dependencies, and a weak/optional ones (IOW, sc-im would run fine if gnuplot or xclip are missing). So I would recommend changing them to `Recommends: gnuplot` and `Recommends: xclip`. See https://rpm-software-management.github.io/rpm/manual/dependencies.html and https://rpm-software-management.github.io/rpm/manual/more_dependencies.html on what the various dependecy specifiers mean. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2331669 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331669%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
