https://bugzilla.redhat.com/show_bug.cgi?id=2331339 --- Comment #16 from Konrad Kleine <kkleine@xxxxxxxxxx> --- Thank you Benson Muite for your review! Changes addressing the comments: - a) License is now "BSD-3-Clause AND MIT" for the main python-nanobind package. - b) Each sub-package now specifies which license it uses. - c) Fixed: python3-nanobind.noarch: W: summary-not-capitalized nanobind: tiny and efficient C++/Python bindings - d) Fixed by installing with executable bit: python3-nanobind-devel.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/nanobind/stubgen.py 644 /usr/bin/env python3 remove the shebang - e) The documentation is available online (https://nanobind.readthedocs.io/) and I don't think it makes sense to include HTML documentation. For LLVM we recently removed the HTML documentation. Other changes: - Instead of bundling the robin_map git submodule I've recreated the necessary structure from the "robin-map-devel" package which we already ship in Fedora. This was needed because the CMake files expect the directory to exist. The resulting sub-package "python3-nanobind-robin-map-devel" contains a license (MIT in this case) and just links to files from the robin-map-devel package on which it depends. - Tests are now being run and we compile the project using cmake. - The Makefile assumes f41 now. - f41 is the minimal version because "python3-scikit-build-core" is required in version >= 0.10 which wasn't met on f40 for example. Also nanobind explicitly requires "robin-map-devel" > 1.3.0 and on f40 we still ship 1.2.2 Spec URL: https://raw.githubusercontent.com/kwk/python-nanobind/d27a54b888d9acfdf04a309c2d87c408f384b6c6/python-nanobind.spec SRPM URL: https://kkleine.fedorapeople.org/python-nanobind-2.4.0-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2331339 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331339%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
