https://bugzilla.redhat.com/show_bug.cgi?id=2331684 --- Comment #12 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Miro Hrončok from comment #7) > The spec is sane. > > Consider using a SourceLicense tag to record the additional licenses. That’s easy enough to do here, and I don’t object to doing it here, but I’m curious – are we moving in the direction of encouraging this across the board in Fedora? It looks like there are fewer than 50 packages currently using SourceLicense in Fedora overall, which is fewer than the number of packages I would add it to if I adapted SourceLicense in my “own” packages. > For help2man consider using %py3_test_envvars. That’s a good idea. It defines more environment variables than I’m doing manually here, but it tidies up the spec file. (In reply to Miro Hrončok from comment #10) > Consider filtering some of those in > https://src.fedoraproject.org/rpms/rpmlint/blob/rawhide/f/rpmlint.config#_451 That’s not a bad idea. I didn’t realize rpmlint carried a generic collection of jargon words. Particularly useful would be [Mm]etapackage, which rpmlint flags on every Python extra metapackage and every Rust feature metapackage. (In reply to Miro Hrončok from comment #11) > https://pagure.io/FedoraReview/pull-request/526 Thanks for looking into that! But why was the python3.13dist(fonttools[unicode]) dependency unsolvable? python3-fonttools+unicode exists and has had appropriate Provides for fonttools[unicode] for a long time. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2331684 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331684%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
