https://bugzilla.redhat.com/show_bug.cgi?id=2329895 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dominik@greysecto | |r.net) | --- Comment #33 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Uwe Klotz from comment #31) > Disclaimer: I am no longer affiliated with the Mixxx project. Just stumbled > over this bug report as a long term Fedora user (and also contributor to > both Fedora and RPM Fusion in the past). > > All failing tests reveal real issues that will affect users. > > The failing test firstSoundTest indicates that cue points and loops won't be > accurate when switching the default decoder(s). Automatically adjusting > track positions when using a different decoder has not been implemented yet. > It was the main reason that prevented switching to FFmpeg for audio > decoding, see https://github.com/mixxxdj/mixxx/issues/10313. Ok, this looks like a valid issue. We can't do much about missing FAAD2 until it's cleared by Red Hat legal folks. > The other failing tests (seekForwardBackward, seekBoundaries) indicate that > decoding M4A files with FFmpeg is not working correctly. Maybe caused by the > same code changes that prevent decoding of many MP3 files: > https://github.com/mixxxdj/mixxx/issues/11923. But I don't understand why you're pointing to this one. All MP3 decoders are permitted and available in Fedora: libmad, libmpg123, FFmpeg. So, if mixxx needs to use a specific one, it can. (In reply to Luís Correia from comment #30) > There were some tests that failed and I took the liberty to comment them. > > However the MIXXX developers said that: > "These tests indicated, that there is an issue with a sample offset using > this MP3 decoder. Which decoder should be used, then? > This means that hotcues from existing Mixxx files/Mixxx library will have a > time offset. > To make this compatible, you need to add/substract this offset but leave the > test case unmodified. > Otherwise all users switching between rpmfusion builds of Mixxx and Fedora > builds of Mixxx will have a lot of trouble adjusting all of there tracks." Was this an e-mail or is there an upstream issue open about this? I think that, apart from FAAD2, all other dependencies are present in Fedora, so I would not expect test failures other than related to AAC decoding. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2329895 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329895%23c33 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
