https://bugzilla.redhat.com/show_bug.cgi?id=2269411 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #71 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There are two rpmlint warnings that might be notable: > bpfman.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/bpfman SSL_CTX_set_cipher_list > bpfman.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/bpfman-rpc SSL_CTX_set_cipher_list However, I know that this is a false positive for any package that uses the "openssl" crate (which provides *bindings* for that function), even if it doesn't actually *call* this function. ============================================================ To summarize: I won't post the full review template here - all aspects of this package have already been thoroughly reviewed. - The package does not contain non-redistributable content. - It builds and installs correctly in rawhide. - Vendored dependencies are handled correctly. - The license tag reflects all content of the package *and* statically linked dependencies. - RPM scriptlets for the systemd service are present. Package APPROVED. ============================================================ One suggestion I have for the future: > Source1: https://dmellado.fedorapeople.org/bpfman/bpfman-%{version}-vendor.tar.xz You don't have to host the vendor.tar.xz file on a public server. That file will just be generated once and then uploaded to the Fedora lookaside cache (with "fedpkg new-sources"), where it will be immutable. Pointing it to a URL (that you own) is not necessary (and in fact, looks a bit strange, for this case). Just use the plain filename, no URL necessary: > Source1: bpfman-%{version}-vendor.tar.xz There's also a typo on line 84 ("fiile"), but that's a very cosmetic issue. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2269411 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202269411%23c71 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
