https://bugzilla.redhat.com/show_bug.cgi?id=2328493 --- Comment #8 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review! (In reply to Fabio Valentini from comment #7) > I am a bit confused why the example code uses a crate that is obviously > targeted at benchmarks, but oh well. Examples using icu_benchmark_macros is indeed an odd choice, especially because that crate is supposed to be for internal use, and nothing documents *why* they are there. This habit appears to be consistent across examples in many icu4x crates. I guess one alternative approach would be to sed-patch the examples to remove or comment any lines with "icu_benchmark_macros::". That would probably work, and might be slightly easier than removing examples/ (and later, patching Cargo.toml to remove references to the examples). > This package is affected by tools confusing the Unicode-3.0 license for > Unicode-DFS-2016. The license text is for Unicode-3.0, matching the crate > metadata. (I need to check whether updating the SPDX license data bundled in > askalono would fix this.) 👍 https://release-monitoring.org/project/375844/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2328493 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202328493%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
