https://bugzilla.redhat.com/show_bug.cgi?id=2331330 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- The manual patch for Cargo.toml is also not documented - it needs at least a short comment. Especially since the patch is wrong. :) crates should have *either* a package.license-file *or* a package.license property in Cargo.toml, but not both. The license-file setting is only for non-standard licenses that cannot be expressed in SPDX form. Since this is the case here (assuming that setting the license to "BSD-3-Clause" is correct?), only package.license should be set. c.f. https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2331330 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202331330%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
