https://bugzilla.redhat.com/show_bug.cgi?id=2330823 --- Comment #9 from Jonathan Steffan <jonathansteffan@xxxxxxxxx> --- (In reply to Davide Cavalca from comment #8) > > # Build features, default off > > %bcond_with x264 > > Could we patch upstream to use OpenH264 ? https://github.com/WiVRn/WiVRn/issues/208 Upstream is actively engaged with this effort so we'll see if it can easily be added. We should continue forward with the package even without software encoding. > > License: GPL-3.0-or-later AND Apache-2.0 AND BSD-2-Clause AND BSD-3-Clause AND BSL-1.0 AND CECILL-C AND CC0-1.0 AND CC-BY-4.0 AND MIT-Khronos-old AND Unlicense AND zlib AND GPL-2.0-or-later AND MIT AND OFL-1.1 > > I think the right identifier for zlib is Zlib (with the capital Z). Also, > CC0-1.0 is normally only allowed for content. Review the blurb on > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ and check > whether we can fit into one of the caveouts, if not this will need a input > from Legal to resolve. I wondered why I saw this but `licensecheck zlib` didn't complain. I've fixed Zlib. I also looked closer at glad and it's dual licensed CC0-1.0 AND Apache-2.0. I've updated this in the spec. > > > %{_datarootdir}/metainfo/io.github.wivrn.wivrn.metainfo.xml > > You should validate this in %check per > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage Resolved. Spec URL: https://jsteffan.fedorapeople.org/imrsv/wivrn.spec SRPM URL: https://jsteffan.fedorapeople.org/imrsv/wivrn-0.22-1.20241206gitv0.22.fc40/wivrn-0.22-1.20241206gitv0.22.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2330823 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330823%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
