https://bugzilla.redhat.com/show_bug.cgi?id=2279244 --- Comment #20 from Davide Cavalca <davide@xxxxxxxxxxxx> --- > License: BSD-3-Clause This needs to also include all the licenses for the bundled libraries > # License: FIXME - unknown > Source10: %{forgeurl10}/archive/%{commit10}/ros_comm-%{commit10}.tar.gz > # License: FIXME - unknown > Source11: %{forgeurl11}/archive/%{commit11}/roscpp_core-%{commit11}.tar.gz This is a hard blocker, we can't include stuff with unknown licensing. > #BuildRequires: pkgconfig(benchmark) > #BuildRequires: pkgconfig(gtest) Add a comment to explain why these are commented out (or put them behind a bcond if that makes more sense). # Fedora pkgconfig(CLI11) = 2.4.2 #Provides: bundled(CLI11) = 2.0.0 Should this be removed? I see you do include the system one in the BRs earlier (likewise for the reference in %prep). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279244 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279244%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
