https://bugzilla.redhat.com/show_bug.cgi?id=2327650 --- Comment #5 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > This package fails to build because it depends on fern v0.6 with the > "colored" feature. Only fern v0.7 has this feature in Fedora. Indeed. A sed line changing to v0.7 supposed to be there. I'll fix this based on your stance on sed lines. > Some other notes: > > > # drop an unused, benchmark-only criterion dev-dependency to speed up builds > > find -name "*.toml" | xargs sed -ri '/^[[:blank:]]*criterion\b/d' > > > > # switch to SQLite available in Fedora > > sed -ri 's/rusqlite = \{ version = "0.30", features = \["chrono", "serde_json", "bundled"\] \}/rusqlite = \{ version = "0.31", features = \["chrono", "serde_json"\] \}/' aw-datastore/Cargo.toml > > > > # switch to fancy-regex available in Fedora > > sed -ri 's/fancy-regex = "0.12.0"/fancy-regex = "0.13.0"/' aw-query/Cargo.toml aw-transform/Cargo.toml > > > > # append current commit to the version string > > sed -ri 's/version = "0.13.1"/version = "0.13.1+%{short_commit}"/' aw-server/Cargo.toml > > > > # remove Android dependencies > > sed -ri '/target_os="android"/,+4d' aw-server/Cargo.toml > > > > # remove a dependency needed only for the vendored package > > sed -ri '/target_os="linux"/,/openssl/d' aw-sync/Cargo.toml > > > > # jemallocator will not be packaged for Fedora, so remove it > > sed -ri '/target_os="linux", target_arch="x86"/,+1d' aw-server/Cargo.toml > > sed -ri '/target_os = "linux", target_arch = "x86"/,/static ALLOC: jemallocator::Jemalloc = jemallocator::Jemalloc;/d' aw-server/src/main.rs > > Please, don't use `sed` for changing Cargo.toml. It is really hard to > understand and debug. A patch would be much simpler and easier to maintain. Could you reconsider letting me keep the sed lines based on the fact that: 1) this is a commit based package, which means it could change frequently from commit to commit 2) the source (aw-server-rust) and the target (fedora) have lots of dependencies that need to match and I believe they'll be changing frequently as well 3) there is also an aw-awatcher package (which I would like to send after this one) which updates dependencies like hell, although old ones work fine, and there I would also like to use sed. A draft spec, where this can be seen, at https://github.com/wojnilowicz/activitywatch-copr/blob/main/aw-awatcher.spec#L207 ? On the contrary, I see that it's easier for me to maintain sed lines in this case, than have to unpack the source, deal with merge conflicts and generate a new patch at each new commit of this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2327650 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202327650%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
