https://bugzilla.redhat.com/show_bug.cgi?id=2329101 --- Comment #4 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > Please don't use NEEDINFO for non-urgent stuff like this. I'll take the > review. needinfo != urgency. thanks > > === > > > # FIXME: no license files detected > > It looks like you intentionally ignored this. > > The project claims it is licensed "(MIT OR Apache-2.0)" (which likely only > applies to the code in src/lib.rs), both of which require redistributed > sources to contain a copy of the license text. > > Additionally, the origin of the test data itself looks dubious. > There is zero documentation on this project, nor any indication of *where* > the contents of the "test_assets" folder comes from, or how it was generated. You could ask the same questions for any open source project. At some point you need to trust someone or conduct your own investigations. There are limits to what I can dig for you. I have recently contributed to picky to allow building the test from released crates. The test data all come from https://github.com/Devolutions/picky-rs/ repository, and released by the picky maintainer Benoit Cortier (https://crates.io/crates/picky-test-data) Regarding the license fields: https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields With the exact same license (MIT OR Apache-2.0): "If a package is using a nonstandard license, then the license-file field may be specified in lieu of the license field." they are standard licenses though. What would you suggest to do? to include the license with the crate? That is not enforced in crates.io, but I suppose the maintainer is ok with that... Can we solve this at the Fedora package level in the meantime? thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2329101 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329101%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
