https://bugzilla.redhat.com/show_bug.cgi?id=2316575 --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to Davide Cavalca from comment #4) > [!]: Package contains no bundled libraries without FPC exception. > > As mentioned above, hidapi needs to be declared > > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > SDL3-static > > I think we need this? > SDL3-static -> SDL3-devel -> SDL3, so I think that's fine. > [x]: %check is present and all tests pass. > [!]: Packages should try to preserve timestamps of original installed > files. > > Sorry I typoed this one, I meant to flag that we're missing %check, and this > has a test suite so we should probably run it if we can > The test suite requires graphics to work, it's currently not straightforward to run. > SDL3-devel.x86_64: E: static-library-without-debuginfo > /usr/lib64/libSDL3_test.a > > I don't think we should ship this This can be used by others, but I did split it out into its own subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2316575 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316575%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
