[Bug 2329411] Review Request: rust-neli-proc-macros - Procedural macros for neli

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2329411



--- Comment #8 from Stefano Brivio <sbrivio@xxxxxxxxxx> ---
(In reply to Stefano Brivio from comment #7)
> (In reply to Fabio Valentini from comment #6)
> > Taking this review.
> 
> Thanks a lot! I'm addressing your comments. I'm currently at point 6.:
> 
> > 6. This project still uses version 1 of the "syn" crate. This version has
> > been obsolete for almost two years at this point, and it will likely fail to
> > parse Rust code that is valid syntax in future Rust versions. Please poke
> > upstream project to port to "syn" v2. In most cases, this should be easy and
> > require little to no code changes.
> 
> ...this one is taking a bit more effort than expected. With syn 2.0.90:
> 
> [...]
>
> ...I'm currently figuring out how to fix those so that I can propose the
> change upstream.

Then I found https://github.com/jbaublitz/neli/pull/241.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2329411

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202329411%23c8

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux