https://bugzilla.redhat.com/show_bug.cgi?id=2318425 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mikel@olasagasti. | |info) | --- Comment #4 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- - generate the name with "go2rpm -q --name ollama github.com/ollama/ollama" to create ollama.spec and also change the name of the BZ - Change this part: > %ifarch x86_64 > %bcond_without rocm > %else > %bcond_with rocm > %endif Switch to: > %bcond rocm 1 - Change this: > make %{?_smp_mflags} Switch to: >%make_build More context: https://fedoraproject.org/wiki/Changes/UseMakeBuildInstallMacro - Wildcard bin: > %{_libdir}/ollama/bin/* Can you list the all the files? > ollama is dependent on installing its runners and other stuff to certain paths relative to the bin/ollama. > Because doing that in %_bindir would not be great, i moved things to _libdir/ollama/ > Is this ok ? I think it's OK, but I suggest to contact packaging@xxxxxxxxxxxxxxxxxxxxxxx for more consensus. > How does staging the bootstrapped source work with fedpkg? There are two options: - Push the spec with boostrap enabled & build it. After push the spec removing the bootstrap bit & build it. - Create a side tag as explained here https://gitlab.com/fedora/sigs/go/go2rpm/-/merge_requests/13#note_1965122324 and follow steps. If it's for one package I would go with any of the options, but if it's for multiple packages I would use the second one. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2318425 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318425%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
