https://bugzilla.redhat.com/show_bug.cgi?id=2312637 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Marc-Andre Lureau from comment #5) > @davide@xxxxxxxxxxxx you need to update the buildrequires list: > %if %{with check} > BuildRequires: crate(bitvec) > BuildRequires: crate(cookie-factory) > BuildRequires: crate(futures) > BuildRequires: crate(futures-macro) > BuildRequires: crate(futures-executor) > BuildRequires: crate(num-bigint) > BuildRequires: crate(slab) > BuildRequires: crate(time) > BuildRequires: crate(time-macros) > %endif I don't know why this is here or why you both think it's required - adding crate dependencies like this is wrong either way, especially without lower / upper version bounds. If the dependencies are missing from the crate, they should be added in Cargo.toml (how that is possible, I don't know), or if the dependencies are needed for tests and they're pulled in by optional / non-default features, add the "-f foo,bar" or even "-a" flag to "%cargo_*" macros (except %cargo_prep) instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2312637 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202312637%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
