[Bug 2279014] Review Request: aws-c-s3 - C99 library implementation for communicating with the S3 service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2279014

Dominik Wombacher <dominik@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(neil@xxxxxxxx)



--- Comment #7 from Dominik Wombacher <dominik@xxxxxxxxxxxx> ---
@neil@xxxxxxxx thanks for doing the review! 
Regarding the SONAME, that comes from upstream, they add the `unstable` suffix
here:
https://github.com/awslabs/aws-c-s3/blob/5877f40f87c77ccf2b278839995a6ee91983080f/CMakeLists.txt#L85
It looks like that the majority of AWS C lib packages had this but dropped that
at some point but it's still in aws-c-s3.
What is your suggestion? Just moving on as is?
Patch it out in our package so that only the version one line up
(https://github.com/awslabs/aws-c-s3/blob/5877f40f87c77ccf2b278839995a6ee91983080f/CMakeLists.txt#L84)
is used?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2279014

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279014%23c7

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux