https://bugzilla.redhat.com/show_bug.cgi?id=2327586 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |benson_muite@xxxxxxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |benson_muite@xxxxxxxxxxxxx --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Issues: ======= - Package must not depend on deprecated() packages. Note: python3-mock is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'MIT and BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-txtorcon See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 125 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python- txtorcon/2327586-python-txtorcon/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.13/site- packages/twisted/plugins/__pycache__(python3-autobahn, python3-carbon, python3-twisted, python3-daphne) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4344 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-txtorcon [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-txtorcon-24.8.0-1.fc42.noarch.rpm python-txtorcon-doc-24.8.0-1.fc42.noarch.rpm python-txtorcon-24.8.0-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4wou2x73')] checks: 32, packages: 3 python-txtorcon-doc.noarch: W: summary-not-capitalized txtorcon documentation python-txtorcon.src: E: spelling-error ('twistd', '%description -l en_US twistd -> twists, twist, twisted') python-txtorcon.src: E: spelling-error ('etcetera', '%description -l en_US etcetera -> tetrameter, racketeer, terrace') python-txtorcon-doc.noarch: E: spelling-error ('twistd', '%description -l en_US twistd -> twists, twist, twisted') python-txtorcon-doc.noarch: E: spelling-error ('etcetera', '%description -l en_US etcetera -> tetrameter, racketeer, terrace') python3-txtorcon.noarch: E: spelling-error ('twistd', '%description -l en_US twistd -> twists, twist, twisted') python3-txtorcon.noarch: E: spelling-error ('etcetera', '%description -l en_US etcetera -> tetrameter, racketeer, terrace') ========= 3 packages and 0 specfiles checked; 6 errors, 1 warnings, 18 filtered, 6 badness; has taken 4.5 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-txtorcon-doc.noarch: W: summary-not-capitalized txtorcon documentation python-txtorcon-doc.noarch: E: spelling-error ('twistd', '%description -l en_US twistd -> twists, twist, twisted') python-txtorcon-doc.noarch: E: spelling-error ('etcetera', '%description -l en_US etcetera -> tetrameter, racketeer, terrace') python3-txtorcon.noarch: E: spelling-error ('twistd', '%description -l en_US twistd -> twists, twist, twisted') python3-txtorcon.noarch: E: spelling-error ('etcetera', '%description -l en_US etcetera -> tetrameter, racketeer, terrace') python-txtorcon-doc.noarch: W: invalid-license BSD python3-txtorcon.noarch: W: invalid-license BSD 2 packages and 0 specfiles checked; 4 errors, 3 warnings, 13 filtered, 4 badness; has taken 1.4 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/t/txtorcon/txtorcon-24.8.0.tar.gz : CHECKSUM(SHA256) this package : befe19138d9c8c5307b6ee6d4fe446d0c201ffd1cc404aeb265ed90309978ad0 CHECKSUM(SHA256) upstream package : befe19138d9c8c5307b6ee6d4fe446d0c201ffd1cc404aeb265ed90309978ad0 Requires -------- python3-txtorcon (rpmlib, GLIBC filtered): python(abi) python3.13dist(automat) python3.13dist(cryptography) python3.13dist(twisted) python3.13dist(twisted[tls]) python3.13dist(zope-interface) python-txtorcon-doc (rpmlib, GLIBC filtered): Provides -------- python3-txtorcon: python-txtorcon python3-txtorcon python3.13-txtorcon python3.13dist(txtorcon) python3dist(txtorcon) python-txtorcon-doc: python-txtorcon-doc Diff spec file in url and in SRPM --------------------------------- --- /home/FedoraPackaging/reviews/python-txtorcon/2327586-python-txtorcon/srpm/python-txtorcon.spec 2024-11-21 19:43:34.792734376 +0300 +++ /home/FedoraPackaging/reviews/python-txtorcon/2327586-python-txtorcon/srpm-unpacked/python-txtorcon.spec 2024-11-20 03:00:00.000000000 +0300 @@ -17,5 +17,5 @@ Summary: Twisted-based Tor controller client Version: 24.8.0 -Release: %autorelease +Release: 1%{?dist} # code: MIT; alabaster sphinx theme: BSD @@ -104,3 +104,60 @@ %changelog -%autochangelog +* Wed Nov 20 2024 Petr Menšík <pemensik@xxxxxxxxxx> - 24.8.0-1 +- Update to 24.8.0 + +* Fri Jan 21 2022 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 21.1.0-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Tue Aug 17 2021 Fabio Valentini <decathorpe@xxxxxxxxx> - 21.1.0-1 +- Update to version 21.1.0. + +* Sun Aug 15 2021 Fabio Valentini <decathorpe@xxxxxxxxx> - 21.0.0-1 +- Update to version 21.0.0. + +* Tue Jul 27 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 20.0.0-6 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Fri Jun 04 2021 Python Maint <python-maint@xxxxxxxxxx> - 20.0.0-5 +- Rebuilt for Python 3.10 + +* Wed Jan 27 2021 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 20.0.0-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Wed Jul 29 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 20.0.0-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Tue May 26 2020 Miro Hrončok <mhroncok@xxxxxxxxxx> - 20.0.0-2 +- Rebuilt for Python 3.9 + +* Sun Apr 05 2020 Fabio Valentini <decathorpe@xxxxxxxxx> - 20.0.0-1 +- Update to version 20.0.0. + +* Thu Jan 30 2020 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 19.1.0-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Thu Sep 12 2019 Fabio Valentini <decathorpe@xxxxxxxxx> - 19.1.0-1 +- Update to version 19.1.0. + +* Mon Aug 19 2019 Miro Hrončok <mhroncok@xxxxxxxxxx> - 19.0.0-6 +- Rebuilt for Python 3.8 + +* Sat Jul 27 2019 Fabio Valentini <decathorpe@xxxxxxxxx> - 19.0.0-5 +- Include upstream patch fixing compatibility with twisted 19.2.1. + +* Fri Jul 26 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 19.0.0-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Sat Feb 02 2019 Fedora Release Engineering <releng@xxxxxxxxxxxxxxxxx> - 19.0.0-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Tue Jan 22 2019 Igor Gnatenko <ignatenkobrain@xxxxxxxxxxxxxxxxx> - 19.0.0-2 +- Enable python dependency generator + +* Sun Jan 20 2019 Fabio Valentini <decathorpe@xxxxxxxxx> - 19.0.0-1 +- Update to version 19.0.0. + +* Thu Nov 22 2018 Fabio Valentini <decathorpe@xxxxxxxxx> - 18.3.0-1 +- Initial package. + Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2327586 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Perl, Haskell, R, C/C++, Ocaml, SugarActivity, fonts, Java, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Consider using the newer python macros b) Consider using signed release on GitHub: https://github.com/meejah/txtorcon/releases/tag/v24.8.0 c) Alabaster theme is BSD-3-Clause : https://github.com/sphinx-doc/alabaster?tab=readme-ov-file thus change MIT and BSD to MIT AND BSD-3-Clause d) Mock is no longer needed, it is part of unittest -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2327586 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202327586%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
