Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vodovod - a pipe connecting game https://bugzilla.redhat.com/show_bug.cgi?id=428973 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-02-03 03:15 EST ------- Created an attachment (id=293826) --> (https://bugzilla.redhat.com/attachment.cgi?id=293826&action=view) Patch to compile against g++43 (In reply to comment #2) > [OK] package must meet Packaging Guidelines Well, I know many reviewers uses check-list style like you. I don't object to it, however I always wonder what this "package must meet Packaging Guidelines" means on this check list. Actually http://fedoraproject.org/wiki/Packaging/Guidelines contains 40 items... Anyway: * This package does not build on dist-f9. http://koji.fedoraproject.org/koji/taskinfo?taskID=392156 A proposed patch is attached. * On build fedora specific compilation flags are not correctly honored ("Compiler flags" of http://fedoraproject.org/wiki/Packaging/Guidelines ) Using -------------------------------------------------------------------- make %{?_smp_mflags} \ CC="%{__cxx} %{optflags}" -------------------------------------------------------------------- is good for this package. - Desktop icon must be updated ("GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) - And actually the description of this package "Vodovod -" is redundant. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review