https://bugzilla.redhat.com/show_bug.cgi?id=2310159 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial review notes: > BuildRequires: gcc make > BuildRequires: binutils-devel elfutils-libelf-devel libcap-devel llvm-devel clang > BuildRequires: python3-docutils > BuildRequires: kernel-devel Can you please reformulate this so it's one per line? That way it's nicer on diffs and such. > %make_install -C src/ prefix=%{_prefix} bash_compdir=%{_sysconfdir}/bash_completion.d/ mandir=%{_mandir} doc-install "bash_compdir=" should be set to "%{bash_completions_dir}" (like so: "bash_compdir=%{bash_completions_dir}") > %{_sysconfdir}/bash_completion.d/bpftool This needs updating to "%{bash_completions_dir}/bpftool" > %{_mandir}/man8/bpftool-cgroup.8.gz > %{_mandir}/man8/bpftool-gen.8.gz > %{_mandir}/man8/bpftool-iter.8.gz > %{_mandir}/man8/bpftool-link.8.gz > %{_mandir}/man8/bpftool-map.8.gz > %{_mandir}/man8/bpftool-prog.8.gz > %{_mandir}/man8/bpftool-perf.8.gz > %{_mandir}/man8/bpftool.8.gz > %{_mandir}/man8/bpftool-net.8.gz > %{_mandir}/man8/bpftool-feature.8.gz > %{_mandir}/man8/bpftool-btf.8.gz > %{_mandir}/man8/bpftool-struct_ops.8.gz This should be simplified to "%{_mandir}/man8/bpftool*.8*". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2310159 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202310159%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
