Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: color-filesystem - Color filesystem layout https://bugzilla.redhat.com/show_bug.cgi?id=431310 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-02-02 20:02 EST ------- The build dependency on gawk isn't needed at all; you might as well get rid of it. It's needed in the kde-filesystem package because that specfile actually calls awk. Packaging-wise, I see nothing wrong with this package. It only contains three directories (two empty) and one set of RPM macros, and macro usage, specfile naming, package naming, permissions, dependencies and directory ownership are all OK. On that I'm inclined to approve this. However, I wonder at the need to make a separate filesystem package for three directories, and the annoyance at needing something to provide color-filesystem forever once this gets in even if it turns out it's not a good idea. Has anyone talked to the maintainer of the filesystem package to see if these three directories could be added? The same goes for the rpm folks and the macros. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review