https://bugzilla.redhat.com/show_bug.cgi?id=2305346 --- Comment #10 from Xose Vazquez Perez <xose.vazquez@xxxxxxxxx> --- (In reply to Michal Schorm from comment #8) > > "fedpkg lint" shows a lot of warnings(595), most of them are files-duplicate(545) > > The 'files-duplicate' likely comes from the test-suite, which contains a lot > of empty files of specific names, e.g. as a pre-recorded test results, which > are then compared to the actual test results. > I'd strongly advise to ignore nearly any linter findings in the > '/usr/share/mysql-test' path, as most of the issues found are expected > behavior specifically crafted for the test-suite. > > Though this one can be fixed: > mysql8.4-test.x86_64: E: file-parent-ownership-mismatch Path > "/usr/share/mysql-test/platform-specific-tests.list" owned by "root" is > stored in directory owned by "mysql" > as that's a downstream file. > > > mysql8.4-server.x86_64: E: non-executable-script /usr/libexec/mysql-scripts-common 644 /bin/sh > > Is that a problem? > This is a helper script. A code that is never meant to be executed directly. > It is sourced by various other scripts in /usr/bin. > That also is the reason why the 'mysql-scripts-common' is in the > /usr/libexec instead of /usr/bin as per FSH. > Since it is only sourced, I don't see a reason for having it executable. > > > mysql8.4-server.x86_64: E: non-standard-dir-perm /var/lib/mysql-files 750 > > mysql8.4-server.x86_64: E: non-standard-dir-perm /var/log/mysql 750 > > This permission is valid in certain use cases - certain category of software > working with MySQL DB is added to the group 'mysql' to get read-only access > to some files it can then monitor and examine, such as the DB server logs. > But such external software should not get write privileges. At the same > time, some data is confidential, so it shouldn't be shared outside the mysql > user & group - e.g. the DB logs again are a great example. > Same with the '/var/lib/mysql-files' which is used as a specific location > for file import / export operations to / from the DB. > > > mysql8.4-server.x86_64: E: missing-dependency-to-logrotate for logrotate script /etc/logrotate.d/mysqld > > mysql8.4-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/mysqld > > The logrotate requires extra manual steps to be set up properly. > The logrotate file has an example configuration, but is all commented out. > That is expected as it needs manual steps to be enabled. > > I will add > Suggests: logrotate > to the SPECfile, so it advertises such feature, but does not pull it in > unnecessarily. > > -- > > The 8.4.3 build succeeded yesterday, so the latests upstream release is > prepared now. > https://copr.fedorainfracloud.org/coprs/mschorm/mysql8.4/build/8268175/ > > -- > > I've added some fixes for the issues you raised and submitted another build. > Fixes can be reviewed here: > > https://gitlab.com/mschorm/centos_rpms_mysql8.4/-/commit/ > 5a0b1778502b973e4ff23df5338677c3b12a7730 Fine. Any rpmlint ERROR should be whitelisted in the mysql8.4.rpmlintrc file. > -- > If you are willing to take the role of reviewer, please assign this ticket > to yourself and move it to ASSIGNED state, so it is clear both to me and > others that this ticket is under active review and does not look for a > reviewer anymore. I can give you a hint to fix some errors, and speed up the process. But I am not in the "packager group", I am sorry, Come on guys! This a review for a critical package that is three months old!. BTW: If you want "steal" some ideas from the upstream vendor: https://repo.mysql.com/yum/mysql-8.4-community/el/9/SRPMS/mysql-community-8.4.3-1.el9.src.rpm https://repo.mysql.com/yum/mysql-8.4-community/fc/41/SRPMS/mysql-community-8.4.3-10.fc41.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2305346 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202305346%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
