Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dzcomm - Dzcomm a RS-232 API/lib https://bugzilla.redhat.com/show_bug.cgi?id=429221 iphands@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW Flag|needinfo?(iphands@xxxxxxxxx)| ------- Additional Comments From iphands@xxxxxxxxx 2008-02-02 17:08 EST ------- (In reply to comment #2) > ! Note > For general packaging guidelines you can refer to > http://fedoraproject.org/wiki/Packaging/Guidelines > http://fedoraproject.org/wiki/Packaging/ReviewGuidelines > > I just did a quick glance at your spec file and just tried to rebuild > your srpm. > > * Rebuild failed. > http://koji.fedoraproject.org/koji/taskinfo?taskID=362863 > It seems that at least texinfo is missing from BuildRequires. Added texinfo > * Fix SourceURL (see "Sourceforge.net" of > http://fedoraproject.org/wiki/Packaging/SourceURL ) Changed dl.sf.net to downloads.sourceforge.net > * Don't use Epoch unless needed. Removed Epoch: 1 > * BuildRoot does not match Fedora guidelines. The package has its own root dir in the zipfile... (I don't know the procedure with this) > * Please make it sure that fedora specific compilation flags are > honored correctly ("Compiler flags" of > http://fedoraproject.org/wiki/Packaging/Guidelines ) > * Compilation flag "-O3" is not allowed for Fedora because this > makes debugging difficult. > * Also "-fomit-frame-pointer" is forbidden > * And please consider to remove "-ffast-math" as this relaxes > calculation precision and may cause debugging difficult. "make %{?_smp_mflags}" changed to "make %{optflags} %{?_smp_mflags}" Does this cover the -O3 flag? Was that being used as the default? (I am not sure how -O3 was making it in there). Removal of -ffast-math? should the %{optflags} take care of this also? Just looked at the configure script... Should I just remove the CFLAGS= line then gcc would default to whatever the environment is set to (wich should be %{optflags})? If so I can patch the configure file. > * We now recommend %defattr(-,root,root,-) changed to %defattr(-,root,root,-) > * Please write the %files entry more verbosely so that we can grasp > what files are installed easily. This one I am at a loss with.... it is just one .a and a bunch of .h files. rpm -ql on the installed packages shows them all. (help please) Sorry for the delay (busy at home and work) and the lack of knowledge on my part. Thanks for the help, -Ian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review