https://bugzilla.redhat.com/show_bug.cgi?id=2324996 --- Comment #3 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- (In reply to Benson Muite from comment #2) > Comments: > a) There are tests available. Can they be run? Unfortunately tests require internet access for downloading a cab-archives from Dropbox. > b) ConvertUTF is bundled and has a different license: > https://github.com/twogood/unshield/tree/main/lib/convert_utf > > md5 is also bundled and has a different license: > https://github.com/twogood/unshield/blob/main/lib/md5/md5c.c > > Output of license checking tool: > > BSD 2-Clause with views sentence > -------------------------------- > unshield-1.5.1-build/unshield-1.5.1/win32_msvc/getopt.h Not used for building and we don't ship it. > > MIT License > ----------- > unshield-1.5.1-build/unshield-1.5.1/LICENSE > unshield-1.5.1-build/unshield-1.5.1/win32_msvc/dirent.h > Not used for building and we don't ship it. > NTP License > ----------- > unshield-1.5.1-build/unshield-1.5.1/lib/md5/md5.h > unshield-1.5.1-build/unshield-1.5.1/lib/md5/md5c.c Switched to OpenSSL version. > Unicode strict > -------------- > unshield-1.5.1-build/unshield-1.5.1/lib/convert_utf/ConvertUTF.c > unshield-1.5.1-build/unshield-1.5.1/lib/convert_utf/ConvertUTF.h > Asked Fedora_legal about a proper SPDX tag for this one. > c) If OpenSSL is included as a dependency, md5 does not need to be bundled: > https://github.com/twogood/unshield/blob/main/CMakeLists.txt#L49 New files: Spec URL: https://peter.fedorapeople.org/packages/re-review/unshield.spec SRPM URL: https://peter.fedorapeople.org/packages/re-review/unshield-1.5.1-1.fc41.src.rpm Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=125921842 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2324996 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202324996%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
